On Thu, Dec 08, 2005 at 10:02:48AM +0200, Mikko Rapeli wrote:
> On Thu, Dec 08, 2005 at 08:13:25AM +0100, Frank Lichtenheld wrote:
> > Please note that there is both a bug report and a patch for this
> > problem already...
>
> Actually --no-same-owner and --no-same-permissions do different things;
> one changes file owners and the other sets permissions. IMHO both should
> be used by dpkg-source.pl tar invocations.
Hmm, sorry for not reading #144571 properly before.
The patch in bug 144571 fixed file ownerships but not the sometimes
funny permissions within the source tar packages. Since --no-same* are
GNU extensions and should be avoided, perhaps the chown call after
extracttar should be supported by a "chmod 0700 -R $tmp" call?
-Mikko
diff -ru dpkg-1.13.11/scripts/dpkg-source.pl
dpkg-1.13.11.mkr1/scripts/dpkg-source.pl
--- dpkg-1.13.11/scripts/dpkg-source.pl 2005-08-17 06:17:31.000000000 +0300
+++ dpkg-1.13.11.mkr1/scripts/dpkg-source.pl 2005-12-08 10:07:55.248749232
+0200
@@ -642,10 +642,12 @@
my $tmp = "$target.tmp-nest";
(my $t = $target) =~ s!.*/!!;
- mkdir($tmp,0755) || &syserr("unable to create `$tmp'");
+ mkdir($tmp,0700) || &syserr("unable to create `$tmp'");
system "chmod", "g-s", $tmp;
print("$progname: unpacking $tarfile\n");
extracttar("$dscdir/$tarfile",$tmp,$t);
+ system "chown", '-R', '-f', join(':',@fowner), "$tmp/$t";
+ system "chmod", '0700', '-R', '-f', "$tmp/$t";
rename("$tmp/$t",$target)
|| &syserr("unable to rename `$tmp/$t' to `$target'");
rmdir($tmp)
Only in dpkg-1.13.11.mkr1/scripts/: dpkg-source.pl.orig
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
