Source: netselect
Source-Version: 0.3.ds1-26
Severity: important
Tags: patch

Hi!

This package is using obsolete absolute paths when stating or calling
dpkg-statoverride. This has been a compatibility symlinks for a while
and got removed in dpkg 1.17.0, I'll reintroduce it in dpkg 1.17.22 but
will be removing it again in 1.18.x.

Please stop using absolute paths in maintainer scripts, as they will
suffer this kind of problem. For more info please see:

<https://lintian.debian.org/tags/command-with-path-in-maintainer-script.html>

although that lintian check does not currently trigger for this issue,
but it should.

Attached a patch fixing this, by always assuming that dpkg-statoverride
is present, which has been true for a very long time now.

Thanks,
Guillem
diff --git a/debian/netselect.postinst b/debian/netselect.postinst
index dc58970..3c86a97 100644
--- a/debian/netselect.postinst
+++ b/debian/netselect.postinst
@@ -4,14 +4,12 @@
 db_get netselect/install-setuid
 
 if [ -x /usr/bin/netselect -a "$RET" = "false" ] ; then
-    if [ -x /usr/sbin/dpkg-statoverride ] && \
-        ! /usr/sbin/dpkg-statoverride --list /usr/bin/netselect >/dev/null; then
+    if ! dpkg-statoverride --list /usr/bin/netselect >/dev/null; then
         chown root:root /usr/bin/netselect
         chmod u=rwx,go=rx /usr/bin/netselect
     fi
 else
-    if [ -x /usr/sbin/dpkg-statoverride ] && \
-        ! /usr/sbin/dpkg-statoverride --list /usr/bin/netselect >/dev/null; then
+    if ! dpkg-statoverride --list /usr/bin/netselect >/dev/null; then
         chown root:root /usr/bin/netselect
         chmod u=rwxs,go=rx /usr/bin/netselect
     fi

Reply via email to