Control: tags -1 patch

On Mon, 2014-11-17 at 13:38:37 +0100, Guillem Jover wrote:
> Source: beep
> Source-Version: 1.3-3
> Severity: important

> The beep package is using obsolete absolute paths when stating or calling
> dpkg-statoverride. This has been a compatibility symlinks for a while
> and got removed in dpkg 1.17.0, I'll reintroduce it in dpkg 1.17.22 but
> will be removing it again in 1.18.x.
> 
> Please stop using absolute paths in maintainer scripts, as they will
> suffer this kind of problem. For more info please see:
> 
> <https://lintian.debian.org/tags/command-with-path-in-maintainer-script.html>
> 
> although that lintian check does not currently trigger for this issue,
> but it should.

Here's a patch fixing this. Always assuming that dpkg-statoverride is
present, which has been true for a very long time now.

Thanks,
Guillem
diff --git a/debian/postinst b/debian/postinst
index fb659d6..95c48a2 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -35,17 +35,7 @@ if [ "$suid" = "not suid at all" ] ; then
 fi
 
 
-if [ -x /usr/sbin/dpkg-statoverride ] ; then
-	if ! dpkg-statoverride --list /usr/bin/beep >/dev/null ; then
-		if [ "$suid" = "usable for all" ] ; then
-			chmod 4755 /usr/bin/beep
-		elif [ "$suid" = "usable for group audio" ] ; then
-			chmod 4754 /usr/bin/beep
-		elif [ "$suid" = "usable only for root" ] ; then
-			chmod 0755 /usr/bin/beep
-		fi
-	fi
-else
+if ! dpkg-statoverride --list /usr/bin/beep >/dev/null ; then
 	if [ "$suid" = "usable for all" ] ; then
 		chmod 4755 /usr/bin/beep
 	elif [ "$suid" = "usable for group audio" ] ; then

Reply via email to