Hi Robert, Ok, I'll have a look at this issue. But I feel like the problem comes from the packages foolish enough to patch the config.* files, not from us.
Anyway, if you have a fix for this [non-]issue, I'll be glad to help our
foolish users ;)
Thanks for your time and your good work on cdbs,
Mt.
On Wed, Feb 09, 2005 at 06:34:27PM +0100, Robert Millan wrote:
> Package: quilt
> Version: 0.37-5
> Severity: important
>
> I'm filing as important, but it could well be serious as it's likely to
> break build on existant packages. Up to you to find out / decide.
>
> We found a problem in cdbs caused by packages attempting to patch
> config.{guess,sub} files. cdbs updates these automaticaly, so when this
> happens the patches end up failing to apply or unapply.
>
> Please look at the changelog for latest cdbs upload (0.4.26-4). The problem
> and the fixes needed are described there in more extension. Currently it is
> in incoming:
> http://incoming.debian.org/cdbs_0.4.26-4_kfreebsd-i386.changes
>
> You most likely need changes in quilt that are equivalent to the ones in
> dpatch.mk (I suggest you use dpatch.mk for reference rather than
> simple-patchsys.mk, for the sake of simplicity).
>
> Quoting from the dpatch.mk log:
>
> > In dpatch.mk:
> > - Always invoke reverse-config before anything else, and update-config
> > after appliing/reverting patches.
>
> This is mandatory for using patches with cdbs. By invoking these targets,
> cdbs uses a backup of config.* files to keep these nasty patches that mangle
> config.* happy, then swap the files to get the source in a buildable state.
>
> > - Add weak dependency on patchutils and use lsdiff to issue a big
> > warning if a patch is updating config.* files.
>
> This is not really necessary, but I encourage you to do the same (cdbs weak
> dependencies are quite simple, just look at dpatch.mk).
>
> > - Assuming that dpatch itself is in charge of idempotency in the
> > apply/reverse targets.
>
> It doesn't matter which part of quilt implements this, but the apply and
> reverse targets must be idempotent or otherwise the config.* files will
> easily get out of sync.
>
> -- System Information:
> Debian Release: 3.1
> APT prefers unstable
> APT policy: (500, 'unstable')
> Architecture: kfreebsd-i386 (i386)
> Kernel: GNU/kFreeBSD 5.3-2
> Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
>
> Versions of packages quilt depends on:
> ii bzip2 1.0.2-3 high-quality block-sorting file
> co
> ii diffstat 1.35-1 produces graph of changes
> introduc
> ii gawk 1:3.1.4-2 GNU awk, a pattern scanning and
> pr
> ii gettext 0.14.1-6 GNU Internationalization
> utilities
> ii libc0.1 2.3-1+kbsd.8 GNU C Library: Shared libraries
> an
> ii patch 2.5.9-2.0.1 Apply a diff file to an original
>
> -- no debconf information
>
signature.asc
Description: Digital signature
