Hello Tim, Michael,

Michael Biebl [2014-10-13  1:01 +0200]:
> > The unit tests in libmediaart require dbus etc, so they can't be run during 
> > package build.
> > They can however run as an autopkgtest.
> > 
> > The attached debdiff enables these tests, and also includes our remaining 
> > ubuntu delta.
> 
> Bringing Martin into the loop here, since he's the autopkgtest expert.
> 
> The patch is at [1]. Martin, I would appreciate your input on this.
> 
> Tim, do we need a dbus system bus? Otherwise using dbus-launch to run a
> user bus should suffice, or not?

For the record, you can emulate a system bus with something like

  dbus-launch sh -c 'export DBUS_SYSTEM_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS 
run_test'

as well, but apparently it only needs a session bus. So indeed running
the tests in debian/rules with dbus-launch should work just fine.

It's not entirely useless to run the upstream tests as autopkgtest,
but the purpose of autopkgtest is really more about testing the
installed package. "make check" doesn't do that, so running the tests
during package build is usually a lot more efficient as you already
have all deps installed and a built tree.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature

Reply via email to