Package: debmake
Version: 4.1.4-1
Severity: important

I have just seen a package come through the Ubuntu NEW queue that used
debmake to prepare it, and had the attached resulting debian/rules file.

First, I think it's bad form for a tool like debmake to output commented-out
examples in its production mode, because many people run the tool and then
never remove the examples, contributing to cruft in the packages uploaded to
the archive.  This was a longstanding bug of dh-make.  If you want to output
examples, please do it in some sort of "tutorial" mode instead of in the
default mode of operation.

Second, /usr/share/dpkg/default.mk (like all make include files) is a
horrible programming interface, reproducing everything that is wrong with
cdbs in a standard tool.  It is not required when using dh - dh makes the
necessary calls to dpkg-buildflags and dpkg-architecture itself.  *Please*
fix debmake to not use such awful interfaces.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[email protected]                                     [email protected]
#!/usr/bin/make -f
# See debhelper(7) (uncomment to enable)
# output every command that modifies files on the build system.
DH_VERBOSE = 1

# see EXAMPLES in dpkg-buildflags(1) and read /usr/share/dpkg/*
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/default.mk

# see FEATURE AREAS in dpkg-buildflags(1)
#export DEB_BUILD_MAINT_OPTIONS = hardening=+all

# see ENVIRONMENT in dpkg-buildflags(1)
# package maintainers to append CFLAGS
#export DEB_CFLAGS_MAINT_APPEND  = -Wall -pedantic
# package maintainers to append LDFLAGS
#export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed


# main packaging script based on dh7 syntax
%:
        dh $@ --with click

# debmake generated override targets
# This is example for Cmake (See http://bugs.debian.org/641051 )
#override_dh_auto_configure:
#       dh_auto_configure -- \
#       -DCMAKE_LIBRARY_PATH=$(DEB_HOST_MULTIARCH)




Attachment: signature.asc
Description: Digital signature

Reply via email to