tag 762312 fixed-upstream
thanks
Hi Sven,
the bug is fixed upstream and the fix will be part of the upcoming
needrestart 1.2 release.
Thanks for reporting & analyzing,
Thomas
On 09/21/2014 06:03 PM, Thomas Liske wrote:
>
> Re,
>
> On 09/21/2014 01:53 PM, Sven Hartge wrote:
>> On Sun, 21 Sep 2014 11:44:29 +0200 Thomas Liske <tho...@fiasko-nw.net>
>> wrote:
>>> On 09/21/2014 03:42 AM, Sven Hartge wrote:
>>
>>>> I noticed needrestart seems to do nothing with systemd as PID1.
>>>
>>> needrestart should work with systemd... could you please provide the
>>> (full) output of:
>>>
>>> - needrestart -vr l
>>> - systemctl status `pidof smokeping`
>>
>> See attachments. This time there are of course different services to be
>> restarted.
>>
>>> If needrestart detects systemd it uses systemctl status to get the
>>> service name to be used to restart a daemon. This might break if the
>>> output of `systemctl status` would differ somewho.
>>
>> I guess this happened after the upgrade to systemd 215, but I am not
> sure.
>
> OK, I'm on jessie which is still on 208. Thanks for your suggestions
> howto fix the regex magic... but I consider to drop the call of
> systemctl to retrieve the service name. Using screen scraping (on
> systemctl status) might be fragile due to:
>
>> This function is intended to generate human-readable output. If you
>> are looking for computer-parsable output, use show instead.
>
> (from systemctl(1) about the 'status' unit command)
>
> The 'show' unit command does not allow to specify a PID, only names/jobs
> are allowed. Maybe needrestart should just read the process's cgroup
> file from procfs to find the service name:
>
> clempner:~# cat /proc/`pidof -s apache2`/cgroup
> 9:hugetlb:/
> 8:blkio:/
> 7:net_cls,net_prio:/
> 6:freezer:/
> 5:devices:/
> 4:memory:/
> 3:cpu,cpuacct:/
> 2:cpuset:/
> 1:name=systemd:/system.slice/apache2.service
>
>
> Viele Grüße,
> Thomas
>
--
:: WWW: http://fiasko-nw.net/~thomas/ ::
::: Jabber: xmpp:tho...@jabber.fiasko-nw.net :::
:: flickr: http://www.flickr.com/photos/laugufe/ ::
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
