Hi Thibaut,
Thibaut Paumard wrote:
> This is what plplot_config.h has to say:
>
> // Configured (by CMake) macros for PLplot that are required for the
> // core build but _not_ required for the build of the installed
> // examples (and presumably any user applications). Therefore, the
> // configured plplot_config.h should not be installed. In contrast,
> // include/plConfig.h.in (note, the configured plConfig.h result
> // #includes plplot_config.h for the core build because HAVE_CONFIG_H
> // is #defined in that case) contains configured macros that are
> // required for the core build, installed examples build, and build of
> // user applications. Therefore, in contrast to plplot_config.h,
> // plConfig.h should be installed.
> //
> // Maintenance issue: in makes no sense to configure duplicate macros
> // for both plplot_config.h and plConfig.h. Therefore, when adding a macro
> // decide which file to put it in depending on whether the result is
> // needed for the installed examples build or not. Furthermore, move
> // configured macros from one file to the other as needed depending on
> // that criterion, but do not copy them.
> //
>
> Actually, there is no config.h in Wheezy's libplplot-dev. Chances are
> gnudatalanguage was taking another config.h (perhaps its own),
I expected to use its own, yes. Didn't check, though.
> which is quite dangerous.
Yes, I'm aware of that. But it worked fine in the past, so I've chosen
that option as short-term hack.
> Based on that, I would say the right fix is no patch plConfig.h to
> contain the macros you need, and not use -DHAVE_CONFIG_H.
>
> #ifdef HAVE_CONFIG_H
> # define HAD_CONFIG_H
> #endif
> #include <plConfig.h>
> #ifdef HAD_CONFIG_H
> # define HAVE_CONFIG_H
> # undef HAD_CONFIG_H
> #endif
I'm not completely getting the intention of that one (despite I like
the idea of HAD_CONFIG_H :-), but the following...
> Actually, the be fix may be to patch the installed version of plConfig.h
> to not include plplot_config.h.
... sounds fine to me, too.
Thanks for your input on this!
Regards, Axel
--
,''`. | Axel Beckert <[email protected]>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
`- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
