block 759008 by 748943 tags 759008 -patch thanks Hi Manuel,
On Sat, Aug 23, 2014 at 02:30:33PM -0400, Manuel Menal wrote: > tdb fails to build on hurd-i386 (blocking ldb and thus samba) because > it uses two features that are not yet implemented on GNU/Hurd: msync(1) > and partial file locking. > > You'll find attached two small patches that make it build. > > The first patch adds a configure test for partial file locking and make > tdb use whole file locking when it's not supported. > > The second one adds a configure test for msync(1) and correct tdb's > code accordingly. > > Please note that this package should be built with 'nocheck' because > some tests do not run well without partial file locking. The tools in > tdbtools/ run fine though. > > Please also note that hurd-any should be added to debian/control so it > gets built on hurd-i386. The whole point of tdb is that it allows multiple concurrent readers/writers, and that is why the various applications that depend on tdb use it. This patch might make tdb build, but it makes it pointless. Any patches to fix tdb on the Hurd the should also pass the test suite, or downstream users risk database corruption and/or other issues. Please fix byte range locking in the Hurd (see the blocking bug I've added), or propose a patch that uses an alternative *and* passes the test suite. Cheers, Jelmer
signature.asc
Description: Digital signature
