Yeah, there's still the -Wunused-result stuff. OK, we can incorporate that...
So just the pbmtojbg* changes need to be incorporated. Cheers, Michael On Tue, Jul 22, 2014 at 12:36 AM, Michael van der Kolff < [email protected]> wrote: > On closer inspection, not quite; we can incorporate the fscanf pedantry - > we probably should upstream that... > > Cheers, > > Michael > > > On Tue, Jul 22, 2014 at 12:30 AM, Michael van der Kolff < > [email protected]> wrote: > >> AFAICT, upstream has incorporated those into pbmtojbg*.c & jbgtopbm*.c. >> Additionally, I have tested the current version with -Wall, and it builds >> clean. >> >> Cheers, >> >> >> Michael >> >> >> On Mon, Jul 21, 2014 at 11:49 PM, Colin Watson <[email protected]> >> wrote: >> >>> On Mon, Jul 21, 2014 at 01:55:29PM +0200, Mathieu Malaterre wrote: >>> > Current packager is working on uploading new upstream: 2.1. Hopefully >>> > upstream did integrate most of your diffs, otherwise we'll just close >>> > it. >>> >>> This implies that you will close this bug if upstream did not integrate >>> all my diffs. Rather, if upstream did not integrate my diffs or the >>> equivalent (e.g. casts so that the code is correct within C89), then >>> please leave this bug open. >>> >>> -- >>> Colin Watson [[email protected]] >>> >> >> >
