Bug#755226: FTBFS with clang instead of gcc

[Alexander]

Source: ddd
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang 
(instead of gcc).

We detected this kinf of error:
http://clang.debian.net/status.php?version=3.4.2&key=WRONG_DEFAULT_DECLARATION

Full build log is available here:
http://clang.debian.net/logs/2014-06-16/ddd_3.3.12-5_unstable_clang.log

Thanks,
Alexander


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- ./ddd/strclass.h	2009-02-11 20:25:06.000000000 +0300
+++ ../ddd-3.3.12-my/./ddd/strclass.h	2014-07-18 22:58:02.271828244 +0400
@@ -811,9 +811,9 @@
 		     const regex& sep);
 
     friend string common_prefix(const string& x, const string& y, 
-				int startpos = 0);
+				int startpos);
     friend string common_suffix(const string& x, const string& y, 
-				int startpos = -1);
+				int startpos);
     friend string replicate(char c, int n);
     friend string replicate(const string& y, int n);
     friend string join(const string *src, int n, const string& sep);
@@ -864,8 +864,8 @@
     friend std::istream& operator>>(std::istream& s, string& x);
 
     friend int readline(std::istream& s, string& x, 
-			char terminator = '\n',
-			int discard_terminator = 1);
+			char terminator,
+			int discard_terminator);
 
     // Status
     unsigned int length() const;
--- ./ddd/DispValue.C	2009-02-11 20:25:07.000000000 +0300
+++ ../ddd-3.3.12-my/./ddd/DispValue.C	2014-07-18 22:59:03.670748474 +0400
@@ -1432,8 +1432,8 @@
 
     for (int i = 1; i < nchildren(); i++)
     {
-	prefix = common_prefix(prefix, child(i)->full_name());
-	suffix = common_suffix(suffix, child(i)->full_name());
+	prefix = common_prefix(prefix, child(i)->full_name(), 0);
+	suffix = common_suffix(suffix, child(i)->full_name(), -1);
     }
 }
 
--- ./ddd/strclass.C	2014-07-18 22:59:48.000000000 +0400
+++ ../ddd-3.3.12-my/./ddd/strclass.C	2014-07-18 22:52:14.053953702 +0400
@@ -1481,7 +1481,7 @@
     return w;
 }
 
-string common_prefix(const string& x, const string& y, int startpos)
+string common_prefix(const string& x, const string& y, int startpos = 0)
 {
     string r;
     if ((int)x.length() + startpos < 0 || (int)y.length() + startpos < 0)
@@ -1501,7 +1501,7 @@
     return r;
 }
 
-string common_suffix(const string& x, const string& y, int startpos) 
+string common_suffix(const string& x, const string& y, int startpos = -1) 
 {
     string r;
     if ((int)x.length() + startpos < 0 || (int)y.length() + startpos < 0)
@@ -1563,7 +1563,7 @@
     return s;
 }
 
-int readline(std::istream& s, string& x, char terminator, int discard)
+int readline(std::istream& s, string& x, char terminator = '\n', int discard = 1)
 {
     assert(!x.consuming());
 
--- ./ddd/complete.C	2009-02-11 20:25:07.000000000 +0300
+++ ../ddd-3.3.12-my/./ddd/complete.C	2014-07-18 22:55:00.675022498 +0400
@@ -354,7 +354,7 @@
 	string common_pfx = completions[0];
 	int i;
 	for (i = 1; i < completions_size; i++)
-	    common_pfx = common_prefix(common_pfx, completions[i]);
+	    common_pfx = common_prefix(common_pfx, completions[i], 0);
 
 	if (completions_size > 1 && input == common_pfx)
 	{
--- ./ddd/exit.C	2009-02-11 20:25:07.000000000 +0300
+++ ../ddd-3.3.12-my/./ddd/exit.C	2014-07-18 22:55:51.994119753 +0400
@@ -478,7 +478,7 @@
 	str_func_ret = "core";
     }
     else {
-	readline(patternfile, pattern);
+	readline(patternfile, pattern, '\n', 1);
 	core_pat = pattern.chars();
 	while(*core_pat)
 	{