Source: ion
Severity: minor
Tags: patch
User: [email protected]
Usertags: clang-ftbfs
Hello,
Using the rebuild infrastructure, your package fails to build with clang
(instead of gcc).
We detected this kinf of error:
http://clang.debian.net/status.php?version=3.4.2&key=TAUTOLOGICAL-COMPARE
Full build log is available here:
http://clang.debian.net/logs/2014-06-16/ion_3.2.0~dfsg1-1_unstable_clang.log
Thanks,
Alexander
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- ion-3.2.0~dfsg1/contrib/dtnperf/al_bp/src/bp_implementations/al_bp_ion_conversions.c 2013-12-31 03:22:22.000000000 +0400
+++ ion-3.2.0~dfsg1-my/contrib/dtnperf/al_bp/src/bp_implementations/al_bp_ion_conversions.c 2014-07-10 00:57:59.813667194 +0400
@@ -194,7 +194,7 @@
ion_statusRpt.creationTime = al_ion_timestamp(bundle_status_report.bundle_id.creation_ts);
ion_statusRpt.deletionTime = al_ion_timeval(bundle_status_report.deletion_ts.secs);
ion_statusRpt.deliveryTime = al_ion_timeval(bundle_status_report.delivery_ts.secs);
- ion_statusRpt.flags = al_ion_bundle_srrFlags(bundle_status_report.flags);
+ ion_statusRpt.flags = al_ion_bundle_srrFlags((al_bp_bundle_delivery_opts_t)bundle_status_report.flags);
ion_statusRpt.forwardTime = al_ion_timeval(bundle_status_report.forwarding_ts.secs);
if(bundle_status_report.flags & BDL_IS_FRAGMENT )
ion_statusRpt.isFragment = 1;
--- ion-3.2.0~dfsg1/contrib/dtnperf/al_bp/src/al_bp_api.c 2013-12-31 03:22:22.000000000 +0400
+++ ion-3.2.0~dfsg1-my/contrib/dtnperf/al_bp/src/al_bp_api.c 2014-07-10 00:55:55.307857852 +0400
@@ -610,7 +610,7 @@
{
if (bundle_object == NULL)
return BP_ENULLPNTR;
- if (buf_len < 0)
+ if (buf_len == 0)
return BP_EINVAL;
al_bp_error_t err;
--- ion-3.2.0~dfsg1/nm/shared/utils/utils.c 2013-12-31 03:22:23.000000000 +0400
+++ ion-3.2.0~dfsg1-my/nm/shared/utils/utils.c 2014-07-10 00:54:14.461632387 +0400
@@ -689,7 +689,7 @@
}
/* Did we go too far? */
- if((size-result_len) < 0)
+ if(((int)size-result_len) < 0)
{
DTNMP_DEBUG_ERR("utils_grab_sdnv","Bounds overrun. Size %d Used %d.",
size, result_len);
--- ion-3.2.0~dfsg1/nm/shared/adm/adm.c 2013-12-31 03:22:22.000000000 +0400
+++ ion-3.2.0~dfsg1-my/nm/shared/adm/adm.c 2014-07-09 00:58:25.093671522 +0400
@@ -967,7 +967,7 @@
/* Step 1 - Data at head of buffer should be a string. Grab len & check. */
len = strlen((char*) buffer);
- if((len < 0) || (len > buffer_len) || (len != data_len))
+ if((len == 0) || (len > buffer_len) || (len != data_len))
{
DTNMP_DEBUG_ERR("adm_print_string", "Bad len %d. Expected %d.",
len, data_len);
--- ion-3.2.0~dfsg1/dtpc/library/libdtpcP.c 2013-12-31 03:22:22.000000000 +0400
+++ ion-3.2.0~dfsg1-my/dtpc/library/libdtpcP.c 2014-07-09 00:53:13.879221573 +0400
@@ -2712,7 +2712,7 @@
Profile *profile;
PsmAddress elt;
time_t currentTime;
- unsigned int lifetime;
+ int lifetime;
int priority = 0;
char dstEid[64];
uvast nodeNbr;
--- ion-3.2.0~dfsg1/dtpc/include/dtpc.h 2013-12-31 03:22:22.000000000 +0400
+++ ion-3.2.0~dfsg1-my/dtpc/include/dtpc.h 2014-07-09 00:46:20.782490392 +0400
@@ -57,7 +57,7 @@
DtpcElisionFn elisionFn,
DtpcSAP *dtpcsapPtr);
-extern int dtpc_send(unsigned int profileID,
+extern int dtpc_send(int profileID,
DtpcSAP sap,
char *dstEid,
unsigned int maxRtx,
--- ion-3.2.0~dfsg1/dtpc/library/libdtpc.c 2013-12-31 03:22:22.000000000 +0400
+++ ion-3.2.0~dfsg1-my/dtpc/library/libdtpc.c 2014-07-09 00:45:42.463156393 +0400
@@ -39,7 +39,7 @@
return getIonWorkingDirectory();
}
-int dtpc_send(unsigned int profileID, DtpcSAP sap, char *dstEid,
+int dtpc_send(int profileID, DtpcSAP sap, char *dstEid,
unsigned int maxRtx, unsigned int aggrSizeLimit,
unsigned int aggrTimeLimit, int lifespan,
BpExtendedCOS *extendedCOS, unsigned char srrFlags,
--- ion-3.2.0~dfsg1/bp/cgr/libcgr.c 2013-12-31 03:22:22.000000000 +0400
+++ ion-3.2.0~dfsg1-my/bp/cgr/libcgr.c 2014-07-09 00:30:29.807283116 +0400
@@ -1805,7 +1805,7 @@
[CgrNoProximateNode] = " NO proximate node",
};
- if (traceType < 0 || traceType >= CgrTraceTypeMax)
+ if (traceType == 0 || traceType >= CgrTraceTypeMax)
{
return "";
}
@@ -1844,7 +1844,7 @@
[CgrLargerNodeNbr] = "initial hop has larger node number",
};
- if (reason < 0 || reason >= CgrReasonMax)
+ if (reason == 0 || reason >= CgrReasonMax)
{
return "";
}
