Source: cowbuilder
Version: 0.73
Severity: normal
Hi,
While working on improving cowpoke, I noticed that cowbuilder was
passing the --debbuildopts option to pbuilder twice, something like
this:
forking: pbuilder build --aptcache ... --debbuildopts -uc -us -j6 --buildplace
... --buildresult ... --debbuildopts -uc -us -j6 --no-targz ...
(I trimmed out the junk, but the order of options there is intact).
This would appear to be because in parameter.c we have:
else if (!strcmp(long_options[index_point].name,"debbuildopts"))
{
/* this is for qemubuilder */
pc.debbuildopts=strdup(optarg);
/* pass it for cowbuilder */
PASS_TO_PBUILDER_WITH_PARAM
}
While in cowbuilder.c we also have:
if (pc->debbuildopts)
{
PBUILDER_ADD_PARAM("--debbuildopts");
PBUILDER_ADD_PARAM(pc->debbuildopts);
}
Which adds it to the pbuildercommandline[] a second time, right
after --buildresult.
One of those can probably go away :)
Cheers,
Ron
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
