block 753891 by 753898 retitle 753891 ITP: GUI for Automated Password Generator (APG) tags 753898 moreinfo thanks
---
Hi Tymon,
Your package has several problems. Initially, try it:
- Remove all useless comments/trash in files (as patches and d/rules).
- Improve the manpage.
> Your manpage must be level 1 but is set as level 8.
> Add the upstream name and your name. See an example here (last lines):
http://sources.debian.net/src/sleuthkit/4.1.3-3/debian/manpages/fcat.1
> Try to format better and add more information. See your manpage using
'man -l apt-gui.1'.
> I suggest txt2man for you.
- Don't use uppercase in executable names.
- Fix all possible lintian alarms. Please, see it:
http://eriberto.pro.br/blog/?p=1289
- Remove empty files (d/docs).
- In d/control the Vcs-* must refer to your packaging, not upstream source code
only.
- Why wrote you the d/source/include-binaries file? What is the goal?
- d/patches/Small-changes has almost 1000 lines. What is this???
- What is the d/patches/New function?
- Finally I stopped my tests because the tarball, when unpacked, didn't
generate the apg-gui-0.1 directory.
I hope this help.
Regards,
Eriberto
pgpztQ0xCTJwq.pgp
Description: PGP signature
