Source: grail
Severity: minor
Tags: patch
User: [email protected]
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang 
(instead of gcc).

We detected this kinf of error:
http://clang.debian.net/status.php?version=3.4.2&key=TAUTOLOGICAL-COMPARE

Full build log is available here:
http://clang.debian.net/logs/2014-06-16/grail_3.1.0-2_unstable_clang.log

Thanks,
Alexander

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- grail-3.1.0/src/subscription.cpp	2012-11-09 20:48:14.000000000 +0400
+++ grail-3.1.0-my/src/subscription.cpp	2014-07-04 00:52:00.901571442 +0400
@@ -105,7 +105,7 @@
 
     case UGSubscriptionPropertyDragTimeout: {
       uint64_t timeout = *reinterpret_cast<const uint64_t*>(value);
-      if (timeout < 0)
+      if (timeout == 0)
         return UGStatusErrorInvalidValue;
       drag_.timeout = timeout;
       return UGStatusSuccess;
@@ -121,7 +121,7 @@
 
     case UGSubscriptionPropertyPinchTimeout: {
       uint64_t timeout = *reinterpret_cast<const uint64_t*>(value);
-      if (timeout < 0)
+      if (timeout == 0)
         return UGStatusErrorInvalidValue;
       pinch_.timeout = timeout;
       return UGStatusSuccess;
@@ -137,7 +137,7 @@
 
     case UGSubscriptionPropertyRotateTimeout: {
       uint64_t timeout = *reinterpret_cast<const uint64_t*>(value);
-      if (timeout < 0)
+      if (timeout == 0)
         return UGStatusErrorInvalidValue;
       rotate_.timeout = timeout;
       return UGStatusSuccess;
@@ -153,7 +153,7 @@
 
     case UGSubscriptionPropertyTapTimeout: {
       uint64_t timeout = *reinterpret_cast<const uint64_t*>(value);
-      if (timeout < 0)
+      if (timeout == 0)
         return UGStatusErrorInvalidValue;
       tap_.timeout = timeout;
       return UGStatusSuccess;

Reply via email to