On Mon, Jun 23, 2014 at 01:44:17PM +0300, Rowan Thorpe wrote: > Attached is a debdiff for several smokeping bugs.
Thanks for your work. I'm not the maintainer (anymore), so just a couple of comments. > + use FindBin; > + # PERL5LIB > +-use lib "$FindBin::Bin/../thirdparty/lib/perl5"; > +-use lib "$FindBin::Bin/../lib"; > ++use lib "/usr/lib/perl5"; > ++use lib "/usr/lib"; Please don't hardcode /usr/lib/perl5. See #748380. /usr/lib makes no sense at all, that's not for perl modules. Just relying on the default perl search path without FindBin or any "use lib" statements should work fine AFAICS. > +- use lib "/usr/local/smokeping/lib"; > +- use lib "/usr/local/rrdtool-1.0.39/lib/perl"; > ++ use lib "/usr/lib"; > ++ use lib "/usr/lib/perl"; /usr/lib/perl is nonsense too (presumably a typo?) -- Niko Tyni nt...@debian.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
