Package: rdesktop
Version: 1.7.1-1
Usertags: goto-cc

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
x86_64-linux-gnu-gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 
-Wformat -Werror=format-security -Wall -Wall -I/usr/include  -pthread 
-I/usr/include/PCSC   -I/usr/include/alsa   -DPACKAGE_NAME=\"rdesktop\" 
-DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.7.1\" 
-DPACKAGE_STRING=\"rdesktop\ 1.7.1\" -DPACKAGE_BUGREPORT=\"\" 
-DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DL_ENDIAN=1 
-DHAVE_SYS_SELECT_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -DHAVE_SYSEXITS_H=1 
-Dssldir=\"/usr\" -DHAVE_XRANDR=1 -DWITH_SCARD=1 
-DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DRDPSND_ALSA=1 
-DHAVE_DIRENT_H=1 -DHAVE_DIRFD=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 
-DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_VFS_H=1 -DHAVE_SYS_STATVFS_H=1 
-DHAVE_SYS_STATFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 
-DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1 
-DHAVE_STRUCT_STATFS_F_NAMELEN=1 -DHAVE_MNTENT_H=1 -DHAVE_SETMNTENT=1 -DIPv6=1 
-DKEYMAP_PATH=\"/usr/share/rdesktop/keymaps/\" -o rdesktop rdesktop.o xwin.o 
xkeymap.o ewmhints.o xclip.o cliprdr.o rdpsnd.o rdpsnd_dsp.o rdpsnd_alsa.o 
tcp.o iso.o mcs.o secure.o licence.o rdp.o orders.o bitmap.o cache.o rdp5.o 
channels.o rdpdr.o serial.o printer.o disk.o parallel.o printercache.o mppc.o 
pstcache.o lspci.o seamless.o ssl.o scard.o -Wl,-z,relro -L/usr/lib 
-L/usr/lib64 -lcrypto  -lXrandr  -lpcsclite   -lasound     -lX11

file xwin.c line 58: error: conflicting types for variable "viewport_mode"
old definition in module rdesktop file rdesktop.c line 127
signed int
new definition in module xwin file xwin.c line 58
unsigned char
Makefile:42: recipe for target 'rdesktop' failed
make[1]: *** [rdesktop] Error 64

This will have undefined behaviour for big endian systems as the wrong byte will
be extracted.

Looking at

http://sources.debian.net/src/rdesktop/1.7.1-1/debian/patches/01_paging.dpatch?hl=32#L32

it seems both RD_BOOL and BOOL are being used here, which apparently expand to
different types.

Best,
Michael

Attachment: pgp5I30h_BEPQ.pgp
Description: PGP signature

Reply via email to