Package: predict
Version: 2.2.3-4
Severity: wishlist
Usertags: goto-cc
Tags: upstream

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
gcc  -g -O2 -Wall   -o gsat main.o support.o interface.o callbacks.o comms.o 
plugins.o db.o prefs.o -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 
-lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 
-lglib-2.0 -lfontconfig -lfreetype   -lm -ldl 

error: conflicting function declarations "on_cb_disconnect_clicked"
old definition in module interface file callbacks.h line 28
void (struct _GtkButton *button, void *user_data)
new definition in module comms file comms.c line 51
void (void)
Makefile:365: recipe for target 'gsat' failed
make[3]: *** [gsat] Error 64
make[3]: Leaving directory 
'/srv/jenkins-slave/workspace/sid-goto-cc-predict/predict-2.2.3/clients/gsat-1.1.0/src'
Makefile:376: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1

According to its definition here

http://sources.debian.net/src/predict/2.2.3-4/clients/gsat-1.1.0/src/callbacks.c?hl=144#L143

on_cb_disconnect_clicked requires two arguments. Yet the declaration here

http://sources.debian.net/src/predict/2.2.3-4/clients/gsat-1.1.0/src/comms.c?hl=51#L51

states that the function takes none, and consequently all calls don't pass any.
This would result in buffer underflows, yet it seems the arguments aren't
actually used at present. With the current declaration, however, the compiler
will not be in a position to provide warnings should this change.

Best,
Michael

PS.: I believe this is an upstream issue, but the control file and thus PTS does
not provide any Homepage information.

Attachment: pgp4EI0HzOHV8.pgp
Description: PGP signature

Reply via email to