Daniel Baumann <[email protected]> writes: > On 06/09/2014 03:57 PM, Gaudenz Steinlin wrote: >> If you already commited this, please update the script with the one in >> the version of the patch attached to this mail. > > afaic not needed, but thanks.
OK, what you commited is something completely different from the script in this bug report. It has some nice additional features. Which is great. But the script is also rather confusing and lacking for several reasons: - In some parts it looks like it should be a general wlan driver selection mechanism. Which would be great, but then overrides are stored in /usr/share/live/config/broadcom-sta/ and the script is called 1190-broadcom-sta. - It uses 14e44 as a first filter in the script. While it's true that the ID of all currently supported devices starts with this string, the broadcom vendor ID is only 14e4. The last 4 is part of the device ID. - The blacklisting logic is the wrong way around. If broadcom-sta is selected as a driver, all entries in /etc/modprobe.d/broadcom-sta-dkms.conf should be blacklisted. If it's not selected, they should NOT be blacklisted. Additionally the wl kernel module should be blacklisted in this case. - checking for a state file makes this script basically useless with persistency on removable media. When moving to live media (ie USB stick) from one system to another you want to rerun this script each time. State files are nice for user preferences, but I don't see a use case for them for hardware configuration. Gaudenz -- Ever tried. Ever failed. No matter. Try again. Fail again. Fail better. ~ Samuel Beckett ~ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
