Package: brandy
Version: 1.20-1
Severity: wishlist
Usertags: goto-cc

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
gcc -Wl,-z,relro  -o brandy src/variables.o src/tokens.o src/graphsdl.o 
src/strings.o src/statement.o src/stack.o src/miscprocs.o src/mainstate.o 
src/lvalue.o src/keyboard.o src/iostate.o src/heap.o src/functions.o 
src/fileio.o src/evaluate.o src/errors.o src/emulate.o src/editor.o 
src/convert.o src/commands.o src/brandy.o src/assign.o src/geom.o -lm -lSDL
src/miscprocs.o: In function `secure_tmpnam':
/srv/jenkins-slave/workspace/sid-goto-cc-brandy/brandy-1.20/src/miscprocs.c:495:
 warning: the use of `tmpnam' is dangerous, better use `mkstemp'

error: conflicting function declarations "recover_program"
old definition in module editor file src/editor.c line 219
void (void)
new definition in module commands file src/editor.h line 43
unsigned char (void)
makefile:34: recipe for target 'brandy' failed
make[1]: *** [brandy] Error 64
make[1]: Leaving directory 
'/srv/jenkins-slave/workspace/sid-goto-cc-brandy/brandy-1.20'
debian/rules:33: recipe for target 'build-stamp' failed
make: *** [build-stamp] Error 2

As the acclaimed return value of recover_program isn't used, really just the
declaration here

http://sources.debian.net/src/brandy/1.20-1/src/editor.h?hl=43#L43

should be fixed to ensure no one ever wrongly uses the non-existent value. While
at it, it may also be worth reviewing the declaration of "validate_program" -
there is no such function.

Best,
Michael

Attachment: pgpGJq0yvZTiy.pgp
Description: PGP signature

Reply via email to