On Mon, May 12, 2014 at 4:05 PM, Mark Brown wrote: >> > Please discuss this with upstream. > >> If you have bug reports in upstream's libminizip support, I'm happy to >> work on them upstream. Last time I checked, it Just Worked (tm).
I'm also willing to help if needed. Chromium currently uses embeded minizip, and I did this work to be able to link against it. >> I don't think it would make sense to go upstream and say "Mark Brown >> is not happy with how contrib/minizip deals with the shared library. >> Discuss" without further details. ;-) > > Well, figuring out if they realise it is building a shared library and > understand the stable ABI requirements that Unix like systems have would > be the main thing I guess. The comments in MiniZip64_info.txt about the > changes for 64 bit are a bit worrying here but seem to mostly refer to > the on disk format rather than the interfaces for users of the library. Fedora has shipped minizip packages [0] since version 19, which has been out for almost a year now, and they seem to be able to make it work, which probably indicates that upstream isn't being too disruptive with respect to the ABI now. Also, it sounds like the minizip64 changes are now in the past, and there isn't anything obvious that would be so disruptive in the near future anyway. Best wishes, Mike [0] https://apps.fedoraproject.org/packages/minizip -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
