On Mon, Apr 21, 2014 at 09:43:00PM +0100, Steve Cotton wrote:
> Are there any changes that would make this feature patch more
> likely to be accepted?

Specifying the alternative tool to use should be done like rmadison
handles URLs.  Something like

  DEBCHECKOUT_ALTERNATE_TOOL_SVN=git-svn …

The value should likely be run through Text::ParseWords' shellwords
function to translate it into an array that we can use to run the
command.

> Particularly, do you want the separate
> whitespace-cleanup patch to be dropped?

Yes, because the whitespace is consistent with our code base.
Indentation is expected to be 4-columns where multiples of 8 are tabs
and spaces otherwise ("set tabstop=8 shiftwidth=4 noexpandtab" in Vim
terms).

Cheers,
-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org>


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to