tags 339696 + patch
thanks
On Fri, Nov 18, 2005 at 12:28:34PM +1100, Geoff Crompton wrote:
> Package: debarchiver
> Version: 0.1.8
> Severity: normal
>
> I think if you set mailtos to something like:
> @mailtos = ('Changed-By', '[EMAIL PROTECTED]');
> and Changed-By ends up having the same email address, then you might get
> emailed twice.
Yes you will.
> I thought this, because I got emailed twice, but then I realised that it
> wasn't because of the same email address, it was because the second one
> was an alias to me. (Which of course your script can't detect).
:)
> But by then I'd already prepared this patch, so I thought I'd show you
> the patch anyway.
Thanks anyway. I'll apply this on next upload.
Regards,
// Ola
> -- System Information:
> Debian Release: 3.1
> Architecture: i386 (i686)
> Kernel: Linux 2.6.8-2-686-smp
> Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
>
> Versions of packages debarchiver depends on:
> ii adduser 3.63 Add and remove users and groups
> ii apt-utils 0.5.28.6 APT utility programs
> ii dpkg-dev 1.10.28 Package building tools for Debian
> ii opalmod 0.1.13 A set of Perl modules for
> various
>
> -- no debconf information
> --- debarchiver.orig 2005-11-18 12:15:48.640511216 +1100
> +++ debarchiver 2005-11-18 12:21:26.084211976 +1100
> @@ -506,6 +506,7 @@
> sub determineMailTo() {
> my $to = "";
> my $toi;
> + my %to_hash;
> foreach $toi (@mailtos) {
> # Expand to email if there is no email address.
> if ($toi !~ /\@/) {
> @@ -521,16 +522,11 @@
> }
> }
> if ($toi !~ /^\s*$/) {
> - if ($to =~ /^\s*$/) {
> - $to = $toi;
> - }
> - else {
> - $to = "$to, $toi";
> - }
> + $to_hash{$toi} = "";
> }
> }
> pdebug(5, "Mail will be sent to $to.");
> - return $to;
> + return join(", ", keys(%to_hash));
> }
>
>
> ###############################################################################
--
--------------------- Ola Lundqvist ---------------------------
/ [EMAIL PROTECTED] Annebergsslingan 37 \
| [EMAIL PROTECTED] 654 65 KARLSTAD |
| +46 (0)54-10 14 30 +46 (0)70-332 1551 |
| http://www.opal.dhs.org UIN/icq: 4912500 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
