Hello all, > You need netbase to be installed for /etc/protocols to be available.
> I can confirm that the package doesn't build correctly when the host > is offline, see below. I fixed both of these issues. Please see attached patch. If no objections arise, I'm planning to NMU this. Of course this is not intended as an offence; it's part of my NM-process to fix an RC bug and prepare an NMU for it. regards, Thijs Kinkhorst
diff -u libcgi-ssi-perl-0.88/debian/changelog libcgi-ssi-perl-0.88/debian/changelog
--- libcgi-ssi-perl-0.88/debian/changelog
+++ libcgi-ssi-perl-0.88/debian/changelog
@@ -1,3 +1,11 @@
+libcgi-ssi-perl (0.88-1.1) unstable; urgency=high
+
+ * NMU for release critical bug.
+ * Add netbase to depends (Closes: #337391).
+ * Skip tests in 'make test' that try to access remote sites.
+
+ -- Thijs Kinkhorst <[EMAIL PROTECTED]> Thu, 17 Nov 2005 02:54:10 +0100
+
libcgi-ssi-perl (0.88-1) unstable; urgency=low
* New upstream release. Closes: #329501.
diff -u libcgi-ssi-perl-0.88/debian/packages libcgi-ssi-perl-0.88/debian/packages
--- libcgi-ssi-perl-0.88/debian/packages
+++ libcgi-ssi-perl-0.88/debian/packages
@@ -41,6 +41,7 @@
Build-Depends-Indep: libwww-perl
Build-Depends-Indep: liburi-perl
Build-Depends-Indep: libtimedate-perl
+Build-Depends-Indep: netbase
%endif
Build: sh
PERL=${PERL:-/usr/bin/perl}
diff -u libcgi-ssi-perl-0.88/debian/control libcgi-ssi-perl-0.88/debian/control
--- libcgi-ssi-perl-0.88/debian/control
+++ libcgi-ssi-perl-0.88/debian/control
@@ -4,7 +4,7 @@
Priority: extra
Standards-Version: 3.6.2
Build-Depends: yada (>= 0.48)
-Build-Depends-Indep: perl (>= 5.8), libhtml-simpleparse-perl, perl-modules, libwww-perl, liburi-perl, libtimedate-perl, yada (>= 0.48)
+Build-Depends-Indep: perl (>= 5.8), libhtml-simpleparse-perl, perl-modules, libwww-perl, liburi-perl, libtimedate-perl, netbase, yada (>= 0.48)
Package: libcgi-ssi-perl
Architecture: all
--- libcgi-ssi-perl-0.88.orig/test.pl
+++ libcgi-ssi-perl-0.88/test.pl
@@ -101,10 +101,12 @@
# include file - with many types of input
# include virtual - with different types of input
-{
- my $ssi = CGI::SSI->new();
- my $html = $ssi->process(q[<!--#include virtual="http://www.yahoo.com"; -->]);
- ok($html =~ /yahoo/i && $html =~ /mail/i,'include virtual 1');
+SKIP: {
+# Thijs Kinkhorst: disable tests that require network access
+# my $ssi = CGI::SSI->new();
+# my $html = $ssi->process(q[<!--#include virtual="http://www.yahoo.com"; -->]);
+# ok($html =~ /yahoo/i && $html =~ /mail/i,'include virtual 1');
+ skip("skipping include virtual 1, remote test",1);
}
# tough to do these well, without more info...
@@ -119,10 +121,12 @@
# exec cgi - with different input
-{
- my $ssi = CGI::SSI->new();
- my $html = $ssi->process(q[<!--#exec cgi="http://www.yahoo.com/"; -->]);
- ok($html =~ /yahoo/i,'exec cgi');
+SKIP: {
+# Thijs Kinkhorst: disable tests that require network access
+# my $ssi = CGI::SSI->new();
+# my $html = $ssi->process(q[<!--#exec cgi="http://www.yahoo.com/"; -->]);
+# ok($html =~ /yahoo/i,'exec cgi');
+ skip("skipping exec cgi, remote test",1);
}
# exec cmd - with different input
@@ -267,13 +271,15 @@
# test cookie support
SKIP: {
- eval "use HTTP::Cookies; 1" or skip("HTTP::Cookies not installed", 1);
- my $jar = HTTP::Cookies->new({});
- $jar->set_cookie(1,'mycookie','COOKIEVAL','/','www.bitperfect.com',80,0,0,100);
-
- my $ssi = CGI::SSI->new(COOKIE_JAR => $jar);
- my $html = $ssi->process(qq[<!--#include virtual="http://www.bitperfect.com/cgi-bin/cgi-ssi/cookietest.cgi"-->]);
- ok($html =~ m'COOKIEVAL', "cookie support");
+# Thijs Kinkhorst: disable tests that require network access
+# eval "use HTTP::Cookies; 1" or skip("HTTP::Cookies not installed", 1);
+# my $jar = HTTP::Cookies->new({});
+# $jar->set_cookie(1,'mycookie','COOKIEVAL','/','www.bitperfect.com',80,0,0,100);
+#
+# my $ssi = CGI::SSI->new(COOKIE_JAR => $jar);
+# my $html = $ssi->process(qq[<!--#include virtual="http://www.bitperfect.com/cgi-bin/cgi-ssi/cookietest.cgi"-->]);
+# ok($html =~ m'COOKIEVAL', "cookie support");
+ skip("skipping cookie test, remote test", 1);
}
SKIP: {
signature.asc
Description: This is a digitally signed message part
