On Saturday 22 March 2014 22:42:02 John David Anglin wrote: [snip] > > AVR32? OK, did you write this patch or did you just copied another > > header from > > Qt source and applied it to parisc? In case you have done the > > latest, did you > > modify anything? Please try to be as verbose as possible, it will > > certainly be > > the best for all of us :-D > > I did not write the new qatomic_parisc.h header file. > > I deleted the old qatomic_parisc.h file, copied qatomic_avr32.h to > qatomic_parisc.h and > changed all instances of "AVR32" to "PARISC" to ensure that the > included header is unique > to parisc. Only three lines are changed in the original avr32 header: > > #ifndef QATOMIC_AVR32_H to #ifndef QATOMIC_PARISC_H > #define QATOMIC_AVR32_H to #define QATOMIC_PARISC_H > #endif // QATOMIC_AVR32_H to #endif // QATOMIC_PARISC_H > > Thus, there is no functional difference between the AVR32 and PARISC > implementations.
Ahhh, then everything is much easier then. It's just a matter of letting the
right people know.
> I understand that m68k is using a similar approach to enable Qt
> support. I learned this
> in a message posted by Thorsten Glaser a few months ago, but I haven't
> seen a m68k
> patch. I believe the message is in a Debian bug report. This is what
> led me to develop
> the change.
>
> > WRT copyright: if you substantially modify a file you also get a
> > copyright
> > right, except the changes are trivial or come from well defined data.
>
> I would prefer not to have copyright on the modified files because of
> the
> commercial licensing of Qt.
This is strange for you to say, as the code will remain 100% libre. If you
want to make things clearer do not heasitate to write me in private (just
because it's off topic for the bug).
> I believe the changes are trivial and simply revert to the atomic
> implementation
> used by all other architectures.
Indeed, this changes everything.
--
<rata> hmm, el enchufe hace chispas...
<-- rata ha dejado este servidor ("Leaving").
<marga> ouch
Visto en #lugfi, irc.freenode.net
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/
signature.asc
Description: This is a digitally signed message part.
