-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Package: x11vnc Version: 0.9.13-1.1+b1 Severity: normal
I emailed Karl some time back but got no response, so reporting here.
Occassionally when I VNC in from work in the morning, x11vnc dies, e.g.:
==================================================================
caught X11 error:
13/12/2013 09:22:25 deleted 120 tile_row polling images.
13/12/2013 09:22:25 Restored X server key autorepeat to: 1
X Error of failed request: BadWindow (invalid Window parameter)
Major opcode of failed request: 20 (X_GetProperty)
Resource id in failed request: 0x400169d
Serial number of failed request: 27297
Current serial number in output stream: 27299
==================================================================
There doesn't appear to be anything seriously wrong with X to my
knowledge here. x11vnc is a 'service' to me, so dying when such a
thing happens is unacceptable - by definition they are not fatal
errors as x11vnc continues to do its job fine when they are ignored.
I have attached the patch used to ignore Xerrors - have ran this for a
few months with no obvious issues.
I don't really expect this to be taken on or upstreamed, its just here
for anyone else that might find it useful. I doubt I'd be able to
fight this as an X Windows issue, unless someone else knows better here.
- --- System information. ---
Architecture: amd64
Kernel: Linux 3.12-1-amd64
Debian Release: jessie/sid
990 testing security.debian.org
990 testing ftp.uk.debian.org
500 unstable ignorantguru.github.com
500 unstable ftp.uk.debian.org
500 quodlibet-unstable www.student.tugraz.at
1 experimental ftp.uk.debian.org
- --- Package information. ---
Depends (Version) | Installed
===================================-+-===============
openssl | 1.0.1f-1
tk | 8.5.0-2.1
x11vnc-data (= 0.9.13-1.1) | 0.9.13-1.1
libavahi-client3 (>= 0.6.16) |
libavahi-common3 (>= 0.6.16) |
libc6 (>= 2.14) |
libgcrypt11 (>= 1.4.5) |
libgnutls26 (>= 2.12.17-0) |
libjpeg8 (>= 8c) |
libssl1.0.0 (>= 1.0.0) |
libvncclient0 (>= 0.9.9) |
libvncserver0 (>= 0.9.9) |
libx11-6 |
libxdamage1 (>= 1:1.1) |
libxext6 |
libxfixes3 |
libxinerama1 |
libxrandr2 |
libxtst6 |
zlib1g (>= 1:1.1.4) |
Package's Recommends field is empty.
Package's Suggests field is empty.--
Libre software on Github: https://github.com/OmegaPhil
FSF member #9442
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/
iQIcBAEBAgAGBQJTGi7PAAoJEBfSPH39wvOPjnEP/3kdDbIyqkPnu5S9w6zhEtQu
0OzQUMcIrklomk/aj5ePaK+Vsi6ln1luNQnKjWHJklZixU1qv2tQxSAFDO00nqYM
0V6bLCu8y2ex6glH/kSCXofJXrSFeSpuntkB6HjMHJrPEhQRNx4w4bfK4zA2Df2l
2yI92jaJCin2NHntBCjbDbjT9pJOp9oxt/+/ZbO5Wsc2u7SvLgNNvoedPeNGp+80
cTkntXDGGsXFAUonkMF31+3Q7CJ/EG2Zb8hs34VqQs9rzKzeEcT0Uglv+DHZYmYi
uDAKC1OpFEa/7U0pyth5Db0jFmEX9BBgene2Nnyx8MUHSf2pMyW0bnW0cg4Gc484
mjyxOlcuhobyW1h4hB3vpRO3yaZjcVUCI7/KgGCnZQSSejt38KUjef9e8p3OndwP
cK+wwqObozT+g+rZx5ROE23ArtcSVQXUcZTGdN/TRZRo5rpS8lGe+aq/a0ZCYySl
wlwlepj0tv01CuWU9+EljigeEr/tTUz+IKfwwbw95cmW7dLspywr9eoiCj5aW4eW
6rX5qBZGkKnw6oTIyxq8Lp2QPzN9EACKTtP/TGn/qWOEKx9BFIicOMJ7oi7eXa9b
4FOZlP2ZSQ0U+EzIlyYZn4jPGzGHJ2LdKKS4xuU1AIUEEha5XUyq2KAVm96kkvP3
onjmqM7ispllr01K9JWQ
=af7c
-----END PGP SIGNATURE-----
diff --git a/x11vnc/cleanup.c b/x11vnc/cleanup.c
index 64675c2..8d41329 100644
--- a/x11vnc/cleanup.c
+++ b/x11vnc/cleanup.c
@@ -321,11 +321,16 @@ static int Xerror(Display *d, XErrorEvent *error) {
}
}
- interrupted(0);
+ /* Debug code
+ * Removing to prevent Xerrors from being fatal */
+ //interrupted(0);
if (d) {} /* unused vars warning: */
- return (*Xerror_def)(d, error);
+ /* Debug code
+ * Random Xerrors must not be fatal */
+ //return (*Xerror_def)(d, error);
+ return 0;
}
void watch_loop(void);
x11vnc-non-fatal-xerrors.diff.sig
Description: PGP signature
