On 25 February 2014 08:08, coldtobi <t...@coldtobi.de> wrote: > Source: maradns > Severity: minor > Tags: patch > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Hi Dariusz, > > when reviewing the package I found that a rule in the Makefile for deadwood is > wrong and not generating DwRandPrime.h if not present. > > As this issue was introduced by a patch already in your package, I attach the > *complete* patch for your convenience. This is the diff on the patch: > > - --- a/debian/patches/deadwood_makefile.patch > +++ b/debian/patches/deadwood_makefile.patch > @@ -2,7 +2,7 @@ Author: Nicholas Bamber <nicho...@periapt.co.uk> > Subject: deadwood source code corrupted during build > Also we don't like binaries with a capital in the name. > Forwarded: not-needed > - -Last-Update: 2012-02-12 > +Last-Update: 2014-02-25 > --- a/deadwood-3.2.05/src/Makefile > +++ b/deadwood-3.2.05/src/Makefile > @@ -20,7 +20,7 @@ > @@ -34,7 +34,7 @@ Last-Update: 2012-02-12 > > DwRandPrime.h: RandomPrime > - if [ -e /dev/urandom ] ; then ./RandomPrime > DwRandPrime.h ; fi > - -+ if [ -e /dev/urandom -a -f DwRandPrime.h ] ; then mv -f > DwRandPrime.h DwRandPrime.h.bak ; ./RandomPrime > DwRandPrime.h ; fi > ++ if [ -e /dev/urandom -a -f DwRandPrime.h ] ; then mv -f DwRandPrime.h > DwRandPrime.h.bak ; fi ; ./RandomPrime > DwRandPrime.h > > note that the only change is to move the "fi" to the left to unconditionally > run ./RandomPrime, and not only if if has been there before. > > (With that patch applied, the current hack in d/rules (copying the backup > d/DwRandPrime.h over the generated file in the clean target) can be replaced > by > just deleting the file in d/clean. d/rules would just be more "cleaner" this > way) > > Thanks! > > - -- > Tobias Frost > > - -- System Information: > Debian Release: jessie/sid > APT prefers unstable > APT policy: (500, 'unstable'), (500, 'testing') > Architecture: amd64 (x86_64) > Foreign Architectures: i386 > > Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores) > Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /bin/dash >
Thank You, this was a dirty hack before. I will include this in the next release. -- Pozdrawiam, Dariusz Dwornikowski, Assistant Institute of Computing Science, Poznań University of Technology www.cs.put.poznan.pl/ddwornikowski/ room 2.7.2 BTiCW | tel. +48 61 665 29 41 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
