On Tue, Jan 21, 2014 at 12:00:45PM -0600, Brian Kroth wrote: > >Please try an update package (attached). Updated patch attached as well. > > That does appear to work
Ok. Vincent, could you test this as well? If so, I will merge two bugreports and prepare an update for stable. > however, I think it's incomplete. Can you elaborate this? E.g. provide some tests. > If you look at rpaf_cleanup() (~line 149), there is code very > similar to the main code in change_remote_ip() that undoes the > operation for keepalive connections, however as it stands in the > original code it has the same issue - namely it only handles IPv4. I don't see issues with keepalive right now: root@wheezy:~# curl -I -H 'X-Forwarded-For: 192.168.1.40' -v http://localhost/ http://localhost/two * About to connect() to localhost port 80 (#0) * Trying ::1... * connected * Connected to localhost (::1) port 80 (#0) > HEAD / HTTP/1.1 > User-Agent: curl/7.26.0 > Host: localhost > Accept: */* > X-Forwarded-For: 192.168.1.40 > * HTTP 1.1 or later with persistent connection, pipelining supported < HTTP/1.1 200 OK HTTP/1.1 200 OK < Date: Wed, 22 Jan 2014 12:17:57 GMT Date: Wed, 22 Jan 2014 12:17:57 GMT < Server: Apache/2.2.22 (Debian) Server: Apache/2.2.22 (Debian) < Last-Modified: Mon, 20 Jan 2014 09:16:02 GMT Last-Modified: Mon, 20 Jan 2014 09:16:02 GMT < ETag: "16-b1-4f063572f7880" ETag: "16-b1-4f063572f7880" < Accept-Ranges: bytes Accept-Ranges: bytes < Content-Length: 177 Content-Length: 177 < Vary: Accept-Encoding Vary: Accept-Encoding < Content-Type: text/html Content-Type: text/html < * Connection #0 to host localhost left intact * Re-using existing connection! (#0) with host (nil) * Connected to (nil) (::1) port 80 (#0) > HEAD /two HTTP/1.1 > User-Agent: curl/7.26.0 > Host: localhost > Accept: */* > X-Forwarded-For: 192.168.1.40 > * HTTP 1.1 or later with persistent connection, pipelining supported < HTTP/1.1 404 Not Found HTTP/1.1 404 Not Found < Date: Wed, 22 Jan 2014 12:17:57 GMT Date: Wed, 22 Jan 2014 12:17:57 GMT < Server: Apache/2.2.22 (Debian) Server: Apache/2.2.22 (Debian) < Vary: Accept-Encoding Vary: Accept-Encoding < Content-Type: text/html; charset=iso-8859-1 Content-Type: text/html; charset=iso-8859-1 * no chunk, no close, no size. Assume close to signal end < * Closing connection #0 > The patch I provided previously attempts to apply the same style fix > to the rpaf_cleanup() code as well. Thus, I'm not sure we need this part. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
