Package: cdbs
Version: 0.4.32
Severity: normal
Tags: patch

Hello,

I'm co-packaging squashfs. The upstream Makefile of squashfs-tools
doesn't have clean target. Instead of doing a two line patch, i prefer
using clean:: target in debian/rules.

Then, i have unset DEB_MAKE_CLEAN_TARGET in debian/rules and added a
clean:: target. However, i have :

[...]
dh_clean
make -C /src/dev/Debian/packages/cdbs-clean/squashfs-2.2r2/squashfs-tools 
CFLAGS="-I/src/dev/Debian/packages/cdbs-clean/squashfs-2.2r2/squashfs-tools 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE" CXXFLAGS="-g -Wall -O2" -k  || true
[...]

So, unsetting DEB_MAKE_CLEAN_TARGET does a make in the source directory,
in contrary to DEB_MAKE_CHECK_TARGET which does nothing if unset. I have
done a small patch which prints a message (like DEB_MAKE_CHECK_TARGET
does) if DEB_MAKE_CLEAN_TARGET is unset. I hope it will be useful.

Regards,
Arnaud Fontaine

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-d500
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)

cdbs depends on no packages.

Versions of packages cdbs recommends:
ii  autotools-dev                 20050803.1 Update infrastructure for config.{
ii  debhelper                     5.0.3      helper programs for debian/rules

-- no debconf information

-- 
Arnaud Fontaine <[EMAIL PROTECTED]> - http://www.andesi.org/ | GPG
Public Key available on pgp.mit.edu | Fingerprint: D792 B8A5 A567 B001
C342 2613 BDF2 A220 5E36 19D3

--- makefile.mk.old     2005-11-11 15:28:12.000000000 +0100
+++ makefile.mk 2005-11-11 15:41:16.000000000 +0100
@@ -39,7 +39,12 @@
 
 clean:: makefile-clean
 makefile-clean::
-       $(DEB_MAKE_INVOKE) -k $(DEB_MAKE_CLEAN_TARGET) || true
+       @if test -n "$(DEB_MAKE_CLEAN_TARGET)"; then \
+         echo $(DEB_MAKE_INVOKE) -k $(DEB_MAKE_CLEAN_TARGET); \
+         $(DEB_MAKE_INVOKE) -k $(DEB_MAKE_CLEAN_TARGET) || true; \
+       else \
+         echo "DEB_MAKE_CLEAN_TARGET unset, not running clean"; \
+       fi
        rm -f debian/stamp-makefile-build
 
 common-install-arch common-install-indep:: common-install-impl

Attachment: pgpOlryJev65u.pgp
Description: PGP signature

Reply via email to