Hi, On Mon, Jan 06, 2014 at 12:08:51PM +0100, Benjamin Drung wrote: > Package: gitpkg > Version: 0.23 > Severity: normal > Tags: patch > > When a git repository has submodules, the content of the submodules won't be > included in the source tarball. That's because git archive does not include > the submodules. You need to call git archive for every submodules. A patch > that does this is attached and tested with git repositories with and without > submodules.
This is definitely something I'd be interested in exploring more and supporting better if there's people who have real repos arranged this way. A few of us have talked about it before, but the sticking point has mostly been that nobody has really found submodules to be a very sane way to do what they needed to do, so figuring out what the export tool ought to do without real examples of how people were using them was putting the cart before the horse somewhat ... Can you point to some example of the repos you are doing this with? I have 2 initial comments on this patch ... - I suspect we'll want to make this optional in some manner, since it seems plausible that there may be repos that have submodules to third party projects that shouldn't actually end up in the export for that project (since they may already be packaged separately in Debian). It may even be the case that there are multiple submodules and _some_ belong in the package being exported but not others. - I'm a little confused by this patch exporting submodules for the debian tree only. In most cases that I tend to imagine, the submodules would be part of the upstream source, not debian patches? So we probably need to do a bit more than just this to make it generally useful, but I'm definitely interested in learning more about what repos you've found submodules to actually be useful in, and how you're working with them, so that we can ground the various theories in some actual live practice but without tying people to only one possible configuration (since I'm sure there are lots of ways people might combine separate repos and I'm definitely sure there's more than I've so far imagined :). Cheers, Ron -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
