Package: munin-libvirt-plugins Version: 0.0.6-1 Severity: important Dear Maintainer,
(from a report I dealt with in the #munin IRC channel)
if a virtual machine name begins with a digit (and nothing prevents
virt-manager from creating such), the libvirt-ifstat fails to escape
that name properly, e.g.
# munin-run libvirt-ifstat
1grml_rx.value 13908
1grml_tx.value 8289
This may cause nasty error in the munin graphing and therefor renders
the plugin unusable in such configurations a.k.a. "major effect on the
usability of a package".
munin's rules about acceptable characters are well-documented. Please
prepend an underline if the first character is not acceptable for
munin (and do not, repeat, do not replace that one with an underline
character).
My python skills are non-existent, however it seems changing canon
def canon(name):
- return re.sub(r"[^a-zA-Z0-9_]", "_", name)
+ return re.sub(r"[^a-zA-Z0-9_]", "_", re.sub(r"^([^a-zA-Z_])", r"_\1",
name))
does the right thing.
And please change the dashes to underline in the munin plugin file
names. They cause trouble and might break in the future.
Christoph
-- System Information:
Debian Release: 7.2
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.10.17 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages munin-libvirt-plugins depends on:
ii munin-node 2.0.6-4+deb7u1+~jj3
ii python 2.7.3-4+deb7u1
ii python-libvirt 0.9.12-11+deb7u4
ii python-libxml2 2.8.0+dfsg1-7+nmu2
munin-libvirt-plugins recommends no packages.
munin-libvirt-plugins suggests no packages.
-- no debconf information
signature.asc
Description: Digital signature
