Bug#338108: psmisc: Segmentation fault with pstree -a

[Paul Martin]

Package: psmisc
Version: 21.8-1
Severity: important
Tags: patch

$ pstree -a
init  
  |-atd
  |-atop -a -w /var/log/atop.log 600
  |-cron
  |-(events/0)
  |-exim4 -bd -q30m
  |-getty 38400 tty1
  |-getty 38400 tty2
  |-getty 38400 tty3
  |-getty 38400 tty4
  |-getty 38400 tty5
  |-getty 38400 tty6
  |-gpm -m /dev/psaux -t autops2 -Rms3
  |-icecast2 -b -c /etc/icecast2/icecast.xml
  |   |-{icecast2}
  |   |-{icecast2}
  |   |-{icecast2}
  |   |-{icecast2}
  |   |-{icecast2}
  |   |-{icecast2}
  |   |-{icecast2}
Segmentation fault

My fault entirely.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-1-686
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)

Versions of packages psmisc depends on:
ii  libc6                         2.3.5-7    GNU C Library: Shared libraries an
ii  libncurses5                   5.5-1      Shared libraries for terminal hand

psmisc recommends no packages.

-- no debconf information

--- src/pstree.c~       2005-10-11 04:18:48.000000000 +0100
+++ src/pstree.c        2005-11-08 08:21:16.000000000 +0000
@@ -648,9 +648,15 @@
                         if ((thread=atoi(dt->d_name)) !=0) {
                            if (thread != pid) {
 #ifdef WITH_SELINUX
-                              add_proc(threadname, thread, pid, st.st_uid, 
NULL, 0, scontext);
+                              if (print_args)
+                                add_proc(threadname, thread, pid, st.st_uid, 
threadname, strlen(threadname)+1, scontext);
+                              else 
+                                add_proc(threadname, thread, pid, st.st_uid, 
NULL, 0, scontext);
 #else  /*WITH_SELINUX*/
-                              add_proc(threadname, thread, pid, st.st_uid, 
NULL, 0);
+                              if (print_args)
+                                add_proc(threadname, thread, pid, st.st_uid, 
threadname, strlen(threadname)+1);
+                              else
+                                add_proc(threadname, thread, pid, st.st_uid, 
NULL, 0);
 #endif /*WITH_SELINUX*/
                            }
                         }