Hi Jack,
I’m the guy that added the readproc code you found suspect.
Please don't think of those buffers as representing a memory leak.
Instead, think of them as being statically allocated like this:
#define MAX_BUFSZ 1024*64*2
static char src_buffer[MAX_BUFSZ],
dst_buffer[MAX_BUFSZ];
However, by being dynamically allocated we realize the following advantages:
1) Control of messaging is retained, if ever there was a true memory shortage.
2) All libproc users need not suffer the memory footprint increase.
Only those calling openproc will have that memory allocated.
If the patch offered was applied, the top program would suffer severe
performance
degradation since it calls openproc/closeproc with every iteration.
As a general rule, any memory under the "still reachable" category is not a
problem.
This is from the valgrind documentation:
"still reachable" means your program is probably ok —
it didn't free some memory it could have.
This is quite common and often reasonable.
I’m going to ask Craig to close this bug report.
Regards,
Jim
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
