Hi, On Mon, Oct 28, 2013 at 03:53:25AM +0000, Zooko O'Whielacronx wrote: > Dear bertagaz: > > • Re: line 50 ² this reminds me of Tahoe-LAFS ticket #725 (“We should > whine if we're running as root.”) ³. I don't suggest any change to the > tahoe-lafs.init script, but it makes me wonder if #725 should be > hardened to "exit with an error if we're running as root". > > ² > http://anonscm.debian.org/gitweb/?p=tahoe/tahoe.git;a=blob;f=debian/tahoe-lafs.init;h=352ee7581a9a1f52ada75e791f542fda4f68ea59#l50 > ³ https://tahoe-lafs.org/trac/tahoe-lafs/ticket/725# We should whine > if we're running as root.
That's interesting, I'll reply on the trac ticket. :) > This also means that if tahoe-lafs.init attempts to stop > multiple nodes, and one or more of those nodes was already > not-running, then the exit code from tahoe-lafs.init will be non-zero, > since attempting to stop a not-running node results in a non-zero exit > code. All of this sounds fine to me! The only change I would suggest > is to put a comment at the top of the file stating this. ☺ Also, would > it be appropriate to have the usage printout include a statement of > this behavior? I can add a comment in the initscript before mailing micah for him to upload the new package. The usage printout should remain short IMO so I believe it might not be the best place to put it. > • Other than that suggestion to add documentation (in the form of a > comment and/or usage printout), I see no problem in this script. It is > much shorter than earlier versions, thanks to the refactoring of > start, restart, and stop into the same code and the delegation of more > functionality to the underlying "tahoe" script, so it was much faster > to read through it, which hopefully means it will get better > review/auditing/debugging in the future. Yeah, this script has matured a lot, collective development rocks! :) Thanks for all your feedbacks anyway, I'm very pleased all of you participate. bert. -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
