Em Thu, Oct 24, 2013 at 11:01:42AM +0200, intrigeri escreveu: > > The patch submitted by Reto Gantenbein is simply and works fine, why not > > implement it in the package? > > What's missing is the upstream maintainer of the rsync handler to test > and ACK it. Also, it seems we might be running into circles, and I'm > afraid we might be re-introducing old bugs when fixing new ones. > See upstream ticket about this: > > https://labs.riseup.net/code/issues/4019
Actually I was waiting feedback to know if either Reto's[1] or my patch[2] introduce any regressions. As I said upstream[3], I'm not satisfied with the current way we're handling excludes/includes. Perhaps with rsync's --exclude-from=FILE and --include-from=FILE we could avoid most of the quotes. I would like an opinion before starting implementing something more robust. In the meanwhile, I suggest we merge my patch[4] into backupninja's master branch. [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=683731#22 [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=683731#27 [3] https://labs.riseup.net/code/issues/4019#note-3 [4] https://git.sarava.org/?p=backupninja.git;a=commitdiff;h=b8b8b46fbaf9acbdc769d311a064ab89bb670ef7 -- rhatto at riseup.net pubkey 66CA01CE2BF2C9B7E8D64E340546823964E39FCA please bring your fingerprint when meeting me
signature.asc
Description: Digital signature
