2013/10/4 Rogério Brito <[email protected]>

> Hi there.
>
> The new version of youtube-dl that I uploaded has a changed completion
> file for bash. Can you please provide some feedback on how bad/well it
> works for you? And, if everything works OK, can you close the bug (or
> let me know, so that I can close it)?
>


Hello,

I found version 2013.10.01-1 in unstable, it still has the same ill
symptoms: the function name contains dash character, and it is going to
break things.
Dash character in variable names is not a good idea, please remove it, or
replace it with underscore.

Here is the test:

$ sh /etc/bash_completion.d/youtube-dl.bash-completion
/etc/bash_completion.d/youtube-dl.bash-completion: line 16: `__youtube-dl':
not a valid identifier


but:
$ bash /etc/bash_completion.d/youtube-dl.bash-completion

(fine)

whereas:

$ ls -l `which sh`
lrwxrwxrwx 1 root root 4 Feb 21  2013 /bin/sh -> bash

so it seems that "sh" is using some stricter rules than regular bash and
this is what happens during login.

-- 
Marius

Reply via email to