Hi,
you're a bit hasty in closing bugs...
On Thu, 12 Sep 2013, Ian Jackson wrote:
> Raphaël Hertzog writes ("Bug#722546: dgit should not pass -i\.git -I.git to
> dpkg-source"):
> > This might be helpful with "1.0" source format that did not ignore those
> > files by default but it's actively bad for newer formats (including
> > "3.0 (native)") where using those options actually restrict the set of
> > ignored files (.git is already ignored by default)
>
> This is deliberate. In particular, for example, .gitignore should not
> be ignored if it exists.
Given that the command line overrides what the maintainer has set in
debian/source/options, you also un-ignore files that the maintainer
said to ignore... for example some generated files that tend to stay
around (that might be, or not, in git).
I find this a poor choice.
> dgit's operating principle is that the git tree object corresponding
> to the git commit corresponds _exactly_ to the results of unpacking
> the source package.
This just means that when you detect a difference you should fallback
to do exactly the same as you do when you import a source package from the
archive, no?
> Therefore the only difference should be .git, which exists in working
> trees but not tree objects.
And what is supposed to happen when you want to mixin the upstream git
repository which has for example a directory that is excluded from the
generated tarball that is used in the debian package?
The debian maintainer might well have added some ignore rule so that
dpkg-source doesn't try to add the entire directory as a new patch.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Discover the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
