On Mon, Jun 28, 2004 at 11:50:33PM -0400, Eric Dorland <[EMAIL PROTECTED]>
wrote:
> * Torsten Hilbrich ([EMAIL PROTECTED]) wrote:
> > Package: mozilla-firefox
> > Version: 0.8-12
> > Severity: minor
> > Tags: patch
> >
> > I'm unable to build mozilla-firefox from source if /bin/sh is not bash:
> >
> > $ ls -l /bin/sh
> > lrwxrwxrwx 1 root root 4 2003-08-31 11:10 /bin/sh -> dash
> >
> > The shell is provided by the following package:
> > ii dash 0.4.26-2 The Debian Almquist Shell
> >
> > Without modification the following error occurs when running
> > "debian/rules build":
> >
> > /usr/bin/make
> > make[1]: Entering directory `/home/torsten/tmp/mozilla-firefox-0.8'
> > make[1]: Leaving directory `/home/torsten/tmp/mozilla-firefox-0.8'
> > make[1]: Entering directory `/home/torsten/tmp/mozilla-firefox-0.8'
> > /usr/bin/make -C config export
> > make[2]: Entering directory `/home/torsten/tmp/mozilla-firefox-0.8/config'
> > nsinstall.c
> > gcc -o host_nsinstall.o -c -DXP_UNIX -pipe MOZ_OPTIMIZE_LDFLAGS =
> > -I../dist/include -I../dist/include
> > -I/home/torsten/tmp/mozilla-firefox-0.8/dist/include/nspr -I/usr/include
> > -I/usr/include -I/usr/include
> > -I/home/torsten/tmp/mozilla-firefox-0.8/dist/include/nspr nsinstall.c
> > gcc: cannot specify -o with -c or -S and multiple compilations
> > make[2]: *** [host_nsinstall.o] Error 1
> > make[2]: Leaving directory `/home/torsten/tmp/mozilla-firefox-0.8/config'
> > make[1]: *** [default] Error 2
> > make[1]: Leaving directory `/home/torsten/tmp/mozilla-firefox-0.8'
> > make: *** [build-stamp] Error 2
> >
> > Solution:
> >
> > If I replace the #!/bin/sh in configure with #!/bin/bash the build
> > works without problems.
>
> Unfortunately I don't accept this solution. configure should be a
> portable bourne shell script, not bash. I will accept patches against
> configure.in that fix any bashisms.
Actually, it's not a bashism that breaks everything, but a bug in dash.
Attached here is a workaround that i will apply to next upload in
experimental.
Mike
diff -ruN mozilla-firefox-1.4.99+1.5rc1.dfsg.orig/configure
mozilla-firefox-1.4.99+1.5rc1.dfsg/configure
--- mozilla-firefox-1.4.99+1.5rc1.dfsg.orig/configure 2005-11-03
12:45:37.000000000 +0000
+++ mozilla-firefox-1.4.99+1.5rc1.dfsg/configure 2005-11-03
12:47:54.000000000 +0000
@@ -14791,7 +14791,7 @@
if test "$enableval" != "no"; then
MOZ_OPTIMIZE=1
if test -n "$enableval" && test "$enableval" != "yes"; then
- MOZ_OPTIMIZE_FLAGS=`echo $enableval | sed -e 's|\\\ | |g'`
+ MOZ_OPTIMIZE_FLAGS=`echo "$enableval" | sed -e 's|\\\ | |g'`
MOZ_OPTIMIZE=2
fi
else
diff -ruN mozilla-firefox-1.4.99+1.5rc1.dfsg.orig/configure.in
mozilla-firefox-1.4.99+1.5rc1.dfsg/configure.in
--- mozilla-firefox-1.4.99+1.5rc1.dfsg.orig/configure.in 2005-11-03
12:45:37.000000000 +0000
+++ mozilla-firefox-1.4.99+1.5rc1.dfsg/configure.in 2005-11-03
12:48:10.000000000 +0000
@@ -5213,7 +5213,7 @@
[ if test "$enableval" != "no"; then
MOZ_OPTIMIZE=1
if test -n "$enableval" && test "$enableval" != "yes"; then
- MOZ_OPTIMIZE_FLAGS=`echo $enableval | sed -e 's|\\\ | |g'`
+ MOZ_OPTIMIZE_FLAGS=`echo "$enableval" | sed -e 's|\\\ | |g'`
MOZ_OPTIMIZE=2
fi
else
