Package: denyhosts Version: 2.6-10 Severity: wishlist *** Please type your report below this line ***
If the user edits denyhosts.conf, its possible for LOCK_FILE (in /etc/denyhosts.conf) and PIDFILE (in /etc/init.d/denyhosts) to end up pointing to different places, without the user necessarily realising this is a problem. With the files in this state, the daemon may not restart reliably. It would be nicer to avoid this (maybe a /etc/defaults/denyhosts file?) but at least we can document the issue. A suggested patch is below. I noticed DENYHOSTS_LOCK in denyhosts_ctl.py is also relevant but as long as the init script and config file have correct values, all will be well, so I don't think it needs to be mentioned. Kind regards Vince diff --git a/debian/README.Debian b/debian/README.Debian index 71f97c7..78a5553 100644 --- a/debian/README.Debian +++ b/debian/README.Debian @@ -12,6 +12,12 @@ some hosts that are blocked by denyhosts. give a short guide for usage. +PID file location +================= +This package codes the PID file location in two possible places: +the /etc/init.d/denyhosts init script (the PIDFILE variable) +and in /etc/denyhosts.conf (the LOCK_FILE variable). +If you change one from its default, make sure to change the other. Foreground Mode (thanks to Robert Edmonds) ========================================== diff --git a/debian/denyhosts.init b/debian/denyhosts.init index 7e0203b..b073526 100644 --- a/debian/denyhosts.init +++ b/debian/denyhosts.init @@ -28,6 +28,7 @@ DESC="DenyHosts" NAME=denyhosts DAEMON=/usr/bin/python DAEMONCTL=/usr/share/denyhosts/denyhosts_ctl.py +# you should make sure PIDFILE matches the LOCK_FILE setting in $CONFIG PIDFILE=/run/$NAME.pid SCRIPTNAME=/etc/init.d/$NAME CONFIG=/etc/denyhosts.conf -- System Information: Debian Release: 6.0.7 APT prefers oldstable APT policy: (990, 'oldstable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-0.bpo.4-amd64 (SMP w/8 CPU cores) Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages denyhosts depends on: ii lsb-base 3.2-23.2squeeze1 Linux Standard Base 3.2 init scrip ii python 2.6.6-3+squeeze7 interactive high-level object-orie denyhosts recommends no packages. denyhosts suggests no packages. -- -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
