I looked at the second patch you sent, on 24 July 2013. Here are some thoughts:
also sprach bilibop project <quid...@poivron.org> [2013.06.29.1651 +0200]: > In [1] (molly-guard: should divert rather than relying on $PATH ordering), > you have suggested to use debconf to divert the sysvint's shutdown > commands, and in a private email (in which you asked me to report > it as a bug - see [2] (molly-guard: SSH_CONNECTION can be kept with > specific sudoers config)), you talked to me about debconf to modify > sudo configuration: (Defaults env_keep+=SSH_CONNECTION). [1] I am really not comfortable with diverting these integral commands. The reason is that there might well be other tools that rely on these and might trip over the requirement for a tty, or unexpected output to stdout. Don't you think this is too intrusive? [2] Instead of setting env_keep globally, I suggest to create a Cmnd_Alias for the commands molly-guard protects, and then to use this syntax: Defaults!MOLLY_GUARD_COMMANDS env_keep+=SSH_CONNECTION > Note that the molly-guard code is not modified: maintainer scripts, > a sudoers file, and another shell script have been added, the Makefile > has been modified to include the new files (and other similar and > debian related things in debian/control, debian/rules). In general, this looks well done. I am really just hesitant to make such changes at the moment, and this is mainly because I know I will not be able to deal with bug reports if they come in over the next months. How would you feel taking over molly-guard maintenance? Then I would suggest that we upload a new package to experimental and get some testers. Cheers, -- .''`. martin f. krafft <madduck@d.o> Related projects: : :' : proud Debian developer http://debiansystem.info `. `'` http://people.debian.org/~madduck http://vcs-pkg.org `- Debian - when you have better things to do than fixing systems
digital_signature_gpg.asc
Description: Digital signature (see http://martin-krafft.net/gpg/sig-policy/999bbcc4/current)
