On 2013-07-29 01:21, Michael Gilbert wrote: > On Sun, Jul 28, 2013 at 6:36 PM, Lukas Anzinger wrote: >> I've noticed that the "get-orig-source" target in debian/rules of >> source package fglrx-driver creates a tarball in a directory above th >> current one. While this is admittely quite handy, I think it's a >> violation of ยง4.9 Debian Policy: >> >>> get-orig-source: >>> [...] >>> This target fetches the most recent version of the original source >>> package [...] and leaves it in the current directory. > > It can also only be invoked from the fglrx-driver directory, violating > another sentence in 4.9, "This target may be invoked in any > directory". That should probably be fixed first.
Well, our get-orig-source target probably violates every sentence in 4.9. And I'm generally fine with this :-) But placing the tarball in ../ is absolutely useless in my usage: it needs to go to ../tarballs to be picked up by svn-buildpackage. And that is clearly something I want to do manually. I have the changes needed to get rid of placing the tarball in ../ ready for commit ... unless someone objects. And while it is possible to fix up d/rules to be callable (for some dummy target) from any location, I don't think it is worth doing so. All dpkg-parsechangelog and include calls need to use paths like $(dir $(lastword $(MAKEFILE_LIST))) Andreas -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
