This one time, at band camp, Sam Morris said:
> tag 625758 + patch
> thanks
> 
> With --disabled-password, the password field is set to '!'; with
> --disabled-login, it is set to '*'. pam_unix checks for both in
> verify_pw_hash:
> 
>       } else if (!p || *hash == '*' || *hash == '!') {
>               retval = PAM_AUTH_ERR;
> 
> Therefore I don't see the use of having both options, unless some other
> software cares about the difference between the two values,

They do mean something different:

From the wikipedia page:

"NP" or "!" or null - No password, the account has no password.
"LK" or "*" - the account is Locked, user will be unable to log-in

There is a semantic difference between the two.  ! in the field says
that authentication with a password should never succeed.  * says that
login should never succeed, even if alternate forms of authentication
(such as ssh keys) are in use.  The above chunk of code is correct if it
is in a password checking routine - both should return false for
authentication.

Cheers,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        [email protected] |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------

Attachment: signature.asc
Description: Digital signature

Reply via email to