Package: xine-plugin
Version: 1.0.2-4
Severity: important
Tags: patch
While making a summary of the supported MIME types of various browser
plugins for <URL: http://wiki.debian.org/DebianEdu/BrowserMultimedia >,
I discovered a typo in the xine-plugin package.
The output from NPP_GetMIMEDescription() is missing a semicolon between
the audio/x-mp3 and audio/x-scpls mime type entries. It is easy to see
when filtering the output using sed "s/;/;\n/g", giving you this list at
the end:
audio/mp3: mp3: MPEG audio;
audio/x-mp3: mp3: MPEG audioaudio/x-scpls: pls: Winamp playlist;
application/smil: smi, smil: SMIL playlist;
application/xspf+xml: xspf: XSPF playlist;
application/x-xine-plugin: : Xine plugin
As you can see, there is no semicolon in front of the Winamp playlist
MIME type. This is because the return value from xine_get_mime_types()
do not have a trailing semicolon. This patch solve the problem:
diff -ur xine-plugin-1.0.2/src/plugin.c xine-plugin-1.0.2-pere/src/plugin.c
--- xine-plugin-1.0.2/src/plugin.c 2008-05-08 13:41:57.000000000 +0000
+++ xine-plugin-1.0.2-pere/src/plugin.c 2013-07-15 09:30:57.331072648 +0000
@@ -1313,10 +1313,11 @@
return NULL;
tmp = xine_get_mime_types (xine);
- len = strlen (tmp) + strlen (PLAYLIST_MIMETYPES) + strlen(PLUGIN_MIMETYPE) +
1;
+ len = strlen (tmp) + strlen (PLAYLIST_MIMETYPES) + strlen(PLUGIN_MIMETYPE) +
2;
dsc = malloc (len);
if (dsc) {
strcpy (dsc, tmp);
+ strcpy (dsc, ";");
strcat (dsc, PLAYLIST_MIMETYPES);
strcat (dsc, PLUGIN_MIMETYPE);
}
--
Happy hacking
Petter Reinholdtsen
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
