Hi Adrian!
On Sat, 22 Jun 2013 17:22:54 +0200
John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> wrote:
> Do you need a sponsor for ttylog?
May have one; I wrote to my previous sponsor (Johann Felix Soden)
yesterday and he responded today advising that he would take a look.
> If yes, I'd be happy to help.
Regardless, I always appreciate a review of my work!
> Your package needs some work, however.
>
> Here's what I found so far:
>
> debian/changelog:
>
> - remove emacs mode settings at the end of file
Meant to ask someone about what that was used for (I've never
used emacs, myself)... Added to my ToDo list...
> - remove trailing space in line:
>
> "* Changed debian/watch to point to Sourceforge. " (line 38)
>
> - further trailing spaces to be removed in lines:
>
> 77, 85, 86, 87, 95, 96
Not sure how I missed those. Added to my ToDo list...
>
> debian/compat:
>
> - please bump to version 9 to enable hardening (also build-dep on
> debhelper (>= 9)
I kept it at v8 for now because of possible backporting issues,
although I see that v9.2 is now in squeeze-backports...
> debian/control:
>
> - are you sure your line for Vcs-Git works that way?
>
> "Vcs-Git: git://git.code.sf.net/p/ttylog/code -b debian"
For that, IIRC, I was going by the new write up in 5.2.26 of Debian
Policy v3.9.4 regarding the (admittedly, optional) way of indicating
the branch that the Debian packaging is on if that is not the
default branch.
> - the long descriptions line wrap too early; you should line
> wrap just below 80 columns which is the maximum allowed
> length
I see your point; added to my ToDo list.
> debian/README.Debian:
>
> - file seems outdated; please update or remove
That I also plan to take care of with the package update for a later
version of ttylog (for which I am also upstream...); this version
(0.25) is by way of getting it caught up in Debian, now that
wheezy has been released.
Robert James Clay
j...@rocasa.us
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
