On Mon, 2013-05-20 at 21:06 +0200, [email protected] wrote: > Package: qcontrol > Version: 0.4.2+svn-r40-3 > Severity: wishlist > > Dear Maintainer, > > The current fanspeed control script causes the fan to jump back and forth > between two speed quite easily, at least on my system (419P). I've modified > the base temp() function to implement a hysteresis loop to prevent that. > > The threshold values are completely arbitrary, I've adjusted all values > downward because my machine rarely ever reaches 40 degrees. Also, I've never > written Lua before so there may be easier ways to do it. However, I hope that > the attached function can find its way into the package (as an example?) so > that others can use it too.
Thanks Arno, I'd been considering something like this but hadn't gotten round to it. My only concern with your approach is that if the temperature spikes from e.g. 30 to 50 degrees the code will ramp up through low and medium to high speed rather than jumping straight to high. Perhaps the new temperature readings come in fast enough to make this a non-problem -- I'd have to check. I suppose it is also the case that if the temperature spikes like that then something is probably actually on fire already ;-) (or should that be :-/) Regardless I think your code is an improvement over what is there today so unless I come up with an approach which addresses that concern too I'll throw it into the next version of the package. FYI you were missing a "then" after the last_fan_setting == "silence" near the end. Ian. -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
