Package: gsw
Version: 3.0.1-1
Severity: normal
Tags: patch

It appears from the python3-all-dev build-depend and the use of dh_python3
in debian/rules that you intend gsw to support python3, but it doesn't.  I've
put together the changes needed as well as a few other clean up items in the
attached debdiff.  
diff -Nru gsw-3.0.1/debian/changelog gsw-3.0.1/debian/changelog
--- gsw-3.0.1/debian/changelog	2012-12-18 09:41:37.000000000 -0500
+++ gsw-3.0.1/debian/changelog	2013-05-22 17:17:30.000000000 -0400
@@ -1,3 +1,14 @@
+gsw (3.0.1-2) UNRELEASED; urgency=low
+
+  * Add python3-gsw package and adjust debian/rules to actually build for
+    both python and python3 as intended
+  * Change from arch any to arch all since there is no arch specific content
+  * Drop unneeded python:Provides
+  * Add missing depends on python-numpy
+  * Update dh_auto_clean override so gsw will build twice in a row
+
+ -- Scott Kitterman <sc...@kitterman.com>  Wed, 22 May 2013 17:07:51 -0400
+
 gsw (3.0.1-1) unstable; urgency=low
 
   * Initial release. (Closes: #696238)
diff -Nru gsw-3.0.1/debian/control gsw-3.0.1/debian/control
--- gsw-3.0.1/debian/control	2012-12-18 09:41:56.000000000 -0500
+++ gsw-3.0.1/debian/control	2013-05-22 17:27:29.000000000 -0400
@@ -2,14 +2,13 @@
 Section: python
 Priority: extra
 Maintainer: Alastair McKinstry <mckins...@debian.org>
-Build-Depends: debhelper (>= 8.1.3~), python-all-dev, python3-all-dev
+Build-Depends: debhelper (>= 8.1.3~), python-all, python3-all
 Standards-Version: 3.9.4.0
 Homepage:  http://pypi.python.org/pypi/gsw/
 
 Package: python-gsw
-Architecture: any
-Depends: ${misc:Depends}, ${python:Depends}
-Provides: ${python:Provides}
+Architecture: all
+Depends: ${misc:Depends}, ${python:Depends}, python-numpy
 Description: Python implementation of the Thermodynamic Equation of Seawater
  This package implements the TEOS-10 Equation of State for seawater.
  TEOS-10 is based on a Gibbs function formulation from which all
@@ -20,3 +19,18 @@
  seawater and ice properties in marine science.
  .
  For further information, see http://www.teos-10.org/
+
+Package: python3-gsw
+Architecture: all
+Depends: ${misc:Depends}, ${python3:Depends}, python3-numpy
+Description: Python 3 implementation of the Thermodynamic Equation of Seawater
+ This package implements the TEOS-10 Equation of State for seawater.
+ TEOS-10 is based on a Gibbs function formulation from which all
+ thermodynamic properties of seawater (density, enthalpy, entropy sound speed,
+ etc.) can be derived in a thermodynamically consistent manner.
+ TEOS-10 was adopted by the Intergovernmental Oceanographic Commission at its
+ 25th Assembly in June 2009 to replace EOS-80 as the official description of
+ seawater and ice properties in marine science.
+ .
+ For further information, see http://www.teos-10.org/
+
diff -Nru gsw-3.0.1/debian/rules gsw-3.0.1/debian/rules
--- gsw-3.0.1/debian/rules	2012-12-18 10:04:41.000000000 -0500
+++ gsw-3.0.1/debian/rules	2013-05-22 17:16:26.000000000 -0400
@@ -8,6 +8,17 @@
 %:
 	dh $@ --with python2,python3
 
+override_dh_auto_install:
+	set -e && for pyvers in $(shell pyversions -sv); do \
+	  python$$pyvers setup.py install --install-layout=deb \
+	    --root $(CURDIR)/debian/python-gsw; \
+        done
+	set -e && for py3vers in $(shell py3versions -sv); do \
+	  python$$py3vers setup.py install --install-layout=deb \
+	    --root $(CURDIR)/debian/python3-gsw; \
+        done
+
 override_dh_auto_clean:
 	dh_auto_clean
 	rm -fr gsw.egg-info
+	rm -fr build

Reply via email to