Hi Teresa,

Thanks for reporting this bug!

On 2013-05-14 at 00:56:35, Teresa e Junior wrote:
> Now and then I get the following error while doing different tasks, but
> I could reproduce it easily by running `mk-build-deps' from the package
> devscripts:
> Insecure $ENV{IFS} while running with -t switch at /usr/bin/rm line 110.
> Insecure dependency in system while running with -t switch
> at /usr/bin/rm line 110.

I tried reproducing the problem like this but was unsuccessful:

  $ mkdir tmp
  $ mk-build-deps sl

> The patch is simple, but it makes safe-rm use the default value for IFS:
> $ set | grep ^IFS=

I've changed your patch slightly (see attached file).

Would you be able to confirm that it fixes your problem? (i.e. you can
reproduce the bug without the patch and the bug goes away after applying it)

Cheers,
Francois
diff --git a/safe-rm b/safe-rm
index b980db5..bedba9b 100755
--- a/safe-rm
+++ b/safe-rm
@@ -101,6 +101,7 @@ foreach (@ARGV) {
 # Prepare for actually deleting the file
 local $ENV{PATH} = q{};                   # pointless untainting
 local $ENV{CDPATH} = q{};                 # pointless untainting
+local $ENV{IFS} = " \t\n";                # pointless untainting
 my $real_rm = '/bin/rm';
 
 # Make sure we're not calling ourselves recursively

Reply via email to