Control: retitle -1 r8168-dkms: fails to build module for kernel 3.8
Control: forwarded -1 https://code.google.com/p/r8168/issues/detail?id=12

> This patch works for me:
> https://launchpadlibrarian.net/136947221/r8168-8.035.00.patch

NACK.

That patch seems to fix the issue for 3.8+ while potentially breaking
the driver on older kernels.

The following (added to the top of r8168_n.c) might do the job, but it
needs to be tested:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,8,0)
#define __devinit
#define __devexit_p(x) x
#endif

A patch needs to be licensed under (or compatible with) GPL2.0+.

And I'd like to see a reference to a kernel commit that removed these
definitions. Or caused breakage otherwise. Or documentation about such a
change.


Andreas


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to