* Giulio Paci <giuliop...@gmail.com>, 2013-04-14, 13:21:
Using "except" without specifying exception type is bad idea:
http://docs.python.org/2/howto/doanddont.html#except
Added 1008_avoid_except_usage_without_type.patch. The situation is not very much different anyway, as the patch just replaces "except" with "except Exception".

Yeah; at least it doesn't swallow KeyboardInterrupt. :)

There are still some instances of "except:" left: in g2p.py and in misc.py.

In mGramCounts.py and LanguageModel.py I see this code:
              self.fname = tempfile.mkstemp('counts')[1]
This leaks a filedescriptor... (This doesn't affect Debian AFAICT, so I'm mentioning it here only if case upstream awakens.)

In February you wrote:
let's wait a few more days before dropping the indentation_fixes.patch.
So, can we drop it now? :) It makes .debian.tar almost as big as .orig.tar...

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to