Bug#705659: Xen scripts use old-skool "ip" command syntax

[Mike]

Package: xen-utils-common
Version: 4.1.4-2
Severity: minor

The syntax that the scripts use prevents one from creating a vif named 
"dev", for example.  Attached is a patch for one script, but the syntax 
that skips using the "dev" keyword is present in other scripts, like 
vif-bridge.

--- xen-network-common.sh.orig	2013-01-22 08:41:49.000000000 -0800
+++ xen-network-common.sh	2013-04-17 23:26:38.311175056 -0700
@@ -85,18 +85,18 @@
     local virtual="$2"
 
     # take interface down ...
-    ip link set ${dev} down
+    ip link set dev ${dev} down
 
     if [ $virtual -ne 0 ] ; then
         # Initialise a dummy MAC address. We choose the numerically
         # largest non-broadcast address to prevent the address getting
         # stolen by an Ethernet bridge for STP purposes.
         # (FE:FF:FF:FF:FF:FF)
-        ip link set ${dev} address fe:ff:ff:ff:ff:ff || true
+        ip link set dev ${dev} address fe:ff:ff:ff:ff:ff || true
     fi
 
     # ... and configure it
-    ip addr flush ${dev}
+    ip address flush dev ${dev}
 }
 
 setup_physical_bridge_port() {
@@ -125,10 +125,10 @@
 
     # Don't add $dev to $bridge if it's already on a bridge.
     if [ -e "/sys/class/net/${bridge}/brif/${dev}" ]; then
-	ip link set ${dev} up || true
+	ip link set dev ${dev} up || true
 	return
     fi
     brctl addif ${bridge} ${dev}
-    ip link set ${dev} up
+    ip link set dev ${dev} up
 }